zddr commented on code in PR #54999:
URL: https://github.com/apache/doris/pull/54999#discussion_r2317930900


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionDesc.java:
##########
@@ -289,4 +296,68 @@ public PartitionInfo toPartitionInfo(List<Column> schema, 
Map<String, Long> part
     public boolean inIdentifierPartitions(String colName) {
         return partitionColNames != null && 
partitionColNames.contains(colName);
     }
+
+    /**
+     *  Convert to PartitionTableInfo
+     */
+    public PartitionTableInfo convertToPartitionTableInfo() {

Review Comment:
   please add some ut



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java:
##########
@@ -236,4 +245,94 @@ public String toSql() {
     public String toString() {
         return toSql();
     }
+
+    /**
+     * translate To PartitionDefinition
+     */
+    public PartitionDefinition translateToPartitionDefinition() {

Review Comment:
   please add some ut



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to