dataroaring commented on code in PR #55608:
URL: https://github.com/apache/doris/pull/55608#discussion_r2317636859
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -3125,24 +3126,38 @@ private TGetSnapshotResult
getSnapshotImpl(TGetSnapshotRequest request, String c
result.getStatus().setStatusCode(TStatusCode.SNAPSHOT_EXPIRED);
result.getStatus().addToErrorMsgs(String.format("snapshot %s is
expired", label));
} else {
- byte[] meta = snapshot.getMeta();
- byte[] jobInfo = snapshot.getJobInfo();
+ long metaSize = snapshot.getMetaSize();
+ long jobInfoSize = snapshot.getJobInfoSize();
+ long snapshotSize = snapshot.getMetaSize() +
snapshot.getJobInfoSize();
+ if (metaSize + jobInfoSize >= Integer.MAX_VALUE) {
+ String msg = String.format(
+ "Snapshot %s is too large (%d bytes > 2GB). Please
enable compression to continue.",
Review Comment:
Please give specific howtos about enable compression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]