eldenmoon commented on code in PR #55124:
URL: https://github.com/apache/doris/pull/55124#discussion_r2315087165


##########
be/src/olap/rowset/segment_v2/variant/variant_column_reader.h:
##########
@@ -118,6 +118,8 @@ class VariantColumnReader : public ColumnReader {
     std::unique_ptr<VariantStatistics> _statistics;
     // key: subcolumn path, value: subcolumn indexes
     std::unordered_map<std::string, TabletIndexes> _variant_subcolumns_indexes;
+    // variant_sparse_column_statistics_size
+    size_t _variant_sparse_column_statistics_size = 0;

Review Comment:
   _variant_sparse_column_statistics_size = 
DEFAULT_VARIANT_MAX_SPARSE_COLUMN_STATS_SIZR



##########
be/src/olap/tablet_schema.h:
##########
@@ -280,6 +289,8 @@ class TabletColumn : public MetadataAdder<TabletColumn> {
     int32_t _variant_max_subcolumns_count = 0;
     PatternTypePB _pattern_type = PatternTypePB::MATCH_NAME_GLOB;
     bool _variant_enable_typed_paths_to_sparse = false;
+    // set variant_max_sparse_column_statistics_size
+    int32_t _variant_max_sparse_column_statistics_size = 10000;

Review Comment:
   add a const value in const.h 
   `static constexpr int DEFAULT_VARIANT_MAX_SPARSE_COLUMN_STATS_SIZE  = 10000`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to