Gabriel39 commented on code in PR #55499: URL: https://github.com/apache/doris/pull/55499#discussion_r2314785037
########## be/src/vec/aggregate_functions/aggregate_function_llm_agg.h: ########## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/PaloInternalService_types.h> + +#include <memory> + +#include "common/status.h" +#include "http/http_client.h" +#include "runtime/query_context.h" +#include "runtime/runtime_state.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/common/string_ref.h" +#include "vec/core/types.h" +#include "vec/functions/llm/llm_adapter.h" + +namespace doris::vectorized { +class AggregateFunctionLLMAggData { +public: + static constexpr const char* separator = "\n"; + static constexpr uint8_t separator_size = 1; Review Comment: ```suggestion static constexpr uint8_t SEPARATOR_SIZE = sizeof(separator); ``` ########## be/src/vec/aggregate_functions/aggregate_function_llm_agg.h: ########## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/PaloInternalService_types.h> + +#include <memory> + +#include "common/status.h" +#include "http/http_client.h" +#include "runtime/query_context.h" +#include "runtime/runtime_state.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/common/string_ref.h" +#include "vec/core/types.h" +#include "vec/functions/llm/llm_adapter.h" + +namespace doris::vectorized { +class AggregateFunctionLLMAggData { +public: + static constexpr const char* separator = "\n"; Review Comment: Use uppercase to represent a const value ########## be/src/vec/aggregate_functions/aggregate_function_llm_agg.h: ########## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/PaloInternalService_types.h> + +#include <memory> + +#include "common/status.h" +#include "http/http_client.h" +#include "runtime/query_context.h" +#include "runtime/runtime_state.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/common/string_ref.h" +#include "vec/core/types.h" +#include "vec/functions/llm/llm_adapter.h" + +namespace doris::vectorized { +class AggregateFunctionLLMAggData { +public: + static constexpr const char* separator = "\n"; + static constexpr uint8_t separator_size = 1; + static constexpr size_t MAX_CONTEXT_SIZE = 128 * 1024; + + ColumnString::Chars data; + bool inited = false; + + static QueryContext* _ctx; + LLMResource _llm_config; Review Comment: We only use '_' as prefix of a private variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
