deardeng commented on code in PR #55342:
URL: https://github.com/apache/doris/pull/55342#discussion_r2306273269


##########
be/src/io/cache/cached_remote_file_reader.cpp:
##########
@@ -48,6 +63,129 @@ bvar::Adder<uint64_t> 
g_skip_cache_sum("cached_remote_reader_skip_cache_sum");
 bvar::Adder<uint64_t> g_skip_local_cache_io_sum_bytes(
         "cached_remote_reader_skip_local_cache_io_sum_bytes");
 
+// no custom launcher needed when using std::thread
+
+// Controller to race two fetchers (e.g., S3 vs peer BE) and signal on first 
success
+struct FetchRangeCntl : std::enable_shared_from_this<FetchRangeCntl> {

Review Comment:
   SingleFlight 作用不一样,single只会并发一个task去ms取数据,其他再等。
   
   这里的需求是同时从peer 和 s3取数据,谁的快用谁的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to