morningman commented on code in PR #55070:
URL: https://github.com/apache/doris/pull/55070#discussion_r2296843179
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalTable.java:
##########
@@ -98,10 +99,26 @@ public Table getPaimonTable(Optional<MvccSnapshot>
snapshot) {
return getOrFetchSnapshotCacheValue(snapshot).getSnapshot().getTable();
}
- private PaimonSnapshotCacheValue getPaimonSnapshotCacheValue() {
+ private PaimonSnapshotCacheValue
getPaimonSnapshotCacheValue(Optional<TableSnapshot> tableSnapshot,
+ Optional<TableScanParams> scanParams) {
makeSureInitialized();
- return
Env.getCurrentEnv().getExtMetaCacheMgr().getPaimonMetadataCache()
- .getPaimonSnapshot(this);
+ if (tableSnapshot.isPresent() || (scanParams.isPresent() &&
scanParams.get().isTag())) {
+ // If a snapshot is specified,
+ // use the specified snapshot and the corresponding schema(not the
latest
+ // schema).
+ try {
+ Snapshot snapshot = PaimonUtil.getPaimonSnapshot(paimonTable,
tableSnapshot, scanParams);
+ return new PaimonSnapshotCacheValue(PaimonPartitionInfo.EMPTY,
+ new PaimonSnapshot(snapshot.id(), snapshot.schemaId(),
paimonTable));
+ } catch (Exception e) {
+ LOG.warn("Failed to get Paimon snapshot for table {}",
paimonTable.name(), e);
+ throw new RuntimeException("Failed to get Paimon snapshot", e);
Review Comment:
Please add root cause in exception error msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
