HappenLee commented on code in PR #55017:
URL: https://github.com/apache/doris/pull/55017#discussion_r2292968835
##########
be/src/vec/functions/llm/llm_functions.cpp:
##########
@@ -71,6 +72,15 @@ Status FunctionLLMClassify::build_prompt(const Block& block,
const ColumnNumbers
return Status::OK();
}
+Status FunctionEmbed::build_prompt(const Block& block, const ColumnNumbers&
arguments,
+ size_t row_num, std::string& prompt) const {
+ const ColumnWithTypeAndName& text_column =
block.get_by_position(arguments[1]);
Review Comment:
so many func `build_prompt` is same, should impl in parent class o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
