Gabriel39 commented on code in PR #10084:
URL: https://github.com/apache/doris/pull/10084#discussion_r969110789
##########
be/src/util/simd/bits.h:
##########
@@ -89,16 +92,31 @@ inline size_t count_zero_num(const int8_t* __restrict data,
size_t size) {
return num;
}
-inline size_t count_zero_num(const int8_t* __restrict data, const uint8_t*
__restrict null_map,
Review Comment:
why remove `__restrict` ?
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -240,13 +240,13 @@ ColumnPtr ColumnDecimal<T>::filter(const IColumn::Filter&
filt, ssize_t result_s
* completely pass or do not pass the filter.
* Therefore, we will optimistically check the parts of `SIMD_BYTES`
values.
*/
- static constexpr size_t SIMD_BYTES = 32;
+ static constexpr size_t SIMD_BYTES = 64;
const UInt8* filt_end_sse = filt_pos + size / SIMD_BYTES * SIMD_BYTES;
while (filt_pos < filt_end_sse) {
- uint32_t mask = simd::bytes32_mask_to_bits32_mask(filt_pos);
+ auto mask = simd::bytes64_mask_to_bits64_mask(filt_pos);
- if (0xFFFFFFFF == mask) {
+ if (0xFFFFFFFFFFFFFFFF == mask) {
Review Comment:
Could you make this mask to a common constexpr? I see it is used in multiple
places.
##########
be/src/util/simd/bits.h:
##########
@@ -89,16 +92,31 @@ inline size_t count_zero_num(const int8_t* __restrict data,
size_t size) {
return num;
}
-inline size_t count_zero_num(const int8_t* __restrict data, const uint8_t*
__restrict null_map,
Review Comment:
This function seems never used. Could we remove it?
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -168,6 +177,49 @@ Status BlockReader::init(const ReaderParams& read_params) {
return Status::OK();
}
+Status BlockReader::next_block_with_aggregation(Block* block, MemPool*
mem_pool,
+ ObjectPool* agg_pool, bool*
eof) {
+ return _block_aggregator ? _agg_next_block(block, mem_pool, agg_pool, eof)
Review Comment:
If agg is push down, we'd better to let `_next_block_func` be
`BlockReader::_agg_next_block` instead of make this condition judgment each time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
