eldenmoon commented on code in PR #55124:
URL: https://github.com/apache/doris/pull/55124#discussion_r2291360368
##########
regression-test/suites/variant_p0/predefine/test_variant_compaction_with_sparse_limit.groovy:
##########
@@ -45,12 +45,12 @@
suite("test_compaction_variant_predefine_with_sparse_limit", "nonConcurrent") {
}
}
Review Comment:
新增show create table 展示variant_max_sparse_column_statistics_size属性的case
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -1868,4 +1877,24 @@ public static boolean
analyzeEnableTypedPathsToSparse(Map<String, String> proper
}
return enableTypedPathsToSparse;
}
+
+ public static int analyzeVariantMaxSparseColumnStatisticsSize(Map<String,
String> properties, int defuatValue)
+
throws AnalysisException {
+ int maxSparseColumnStatisticsSize = defuatValue;
+ if (properties != null &&
properties.containsKey(PROPERTIES_VARIANT_MAX_SPARSE_COLUMN_STATISTICS_SIZE)) {
+ String maxSparseColumnStatisticsSizeStr =
+
properties.get(PROPERTIES_VARIANT_MAX_SPARSE_COLUMN_STATISTICS_SIZE);
+ try {
+ maxSparseColumnStatisticsSize =
Integer.parseInt(maxSparseColumnStatisticsSizeStr);
+ if (maxSparseColumnStatisticsSize < 0 ||
maxSparseColumnStatisticsSize > 10000) {
+ throw new
AnalysisException("variant_max_sparse_column_statistics_size must between 0 and
10000 ");
Review Comment:
大于10000很正常的值,改成是(0, 50000)
##########
regression-test/suites/fault_injection_p0/test_variant_compaction_with_sparse_limit.groovy:
##########
@@ -45,17 +45,17 @@ suite("test_compaction_variant_with_sparse_limit",
"nonConcurrent") {
}
}
- set_be_config("variant_max_sparse_column_statistics_size", "2")
- int max_subcolumns_count = Math.floor(Math.random() * 5)
+ int max_subcolumns_count = Math.floor(Math.random() * 5)
+ int max_sparse_column_statistics_size = 2
if (max_subcolumns_count == 1) {
max_subcolumns_count = 0
}
def create_table = { tableName, buckets="auto", key_type="DUPLICATE" ->
sql "DROP TABLE IF EXISTS ${tableName}"
- def var_def = "variant
<properties(\"variant_max_subcolumns_count\" = \"${max_subcolumns_count}\")>"
+ def var_def = "variant
<properties(\"variant_max_subcolumns_count\" = \"${max_subcolumns_count}\",
\"variant_max_sparse_column_statistics_size\" =
\"${max_sparse_column_statistics_size}\")>"
Review Comment:
删除上面的 set_be_config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
