HappenLee commented on code in PR #55056:
URL: https://github.com/apache/doris/pull/55056#discussion_r2289982101
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -713,17 +713,17 @@ struct TrimUtil {
return Status::OK();
}
};
-template <bool is_ltrim, bool is_rtrim, bool trim_single>
+template <bool is_ltrim, bool is_rtrim>
struct TrimInUtil {
static Status vector(const ColumnString::Chars& str_data,
const ColumnString::Offsets& str_offsets, const
StringRef& remove_str,
ColumnString::Chars& res_data, ColumnString::Offsets&
res_offsets) {
const size_t offset_size = str_offsets.size();
res_offsets.resize(offset_size);
res_data.reserve(str_data.size());
- bool all_ascii = simd::VStringFunctions::is_ascii(remove_str) &&
- simd::VStringFunctions::is_ascii(StringRef(
- reinterpret_cast<const
char*>(str_data.data()), str_data.size()));
+ // If remove_str contains only ASCII characters, there is no need to
consider whether str contains UTF-8 characters,
Review Comment:
how make sure the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
