bobhan1 commented on code in PR #53540:
URL: https://github.com/apache/doris/pull/53540#discussion_r2289796233


##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -348,6 +349,22 @@ class RowsetMeta : public MetadataAdder<RowsetMeta> {
 
     int64_t newest_write_timestamp() const { return 
_rowset_meta_pb.newest_write_timestamp(); }
 
+    // for cloud only
+    bool has_visible_time_ms() const { return 
_rowset_meta_pb.has_visible_time_ms(); }
+    int64_t visible_time_ms() const { return 
_rowset_meta_pb.visible_time_ms(); }

Review Comment:
   use macros to define functions only used in UT can reduce the binary size of 
release package.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to