morningman commented on code in PR #12275:
URL: https://github.com/apache/doris/pull/12275#discussion_r967029665
##########
be/src/runtime/plan_fragment_executor.cpp:
##########
@@ -172,6 +172,9 @@ Status PlanFragmentExecutor::prepare(const
TExecPlanFragmentParams& request,
vectorized::VScanNode* scan_node =
static_cast<vectorized::VScanNode*>(scan_nodes[i]);
const std::vector<TScanRangeParams>& scan_ranges =
find_with_default(params.per_node_scan_ranges,
scan_node->id(), no_scan_ranges);
+ LOG(INFO) << "per_node_scan_ranges size " <<
params.per_node_scan_ranges.size();
Review Comment:
Remove debug log
##########
be/src/vec/exec/scan/new_file_scan_node.cpp:
##########
@@ -27,8 +27,11 @@ namespace doris::vectorized {
NewFileScanNode::NewFileScanNode(ObjectPool* pool, const TPlanNode& tnode,
const DescriptorTbl& descs)
- : VScanNode(pool, tnode, descs), _file_scan_node(tnode.file_scan_node)
{
+ : VScanNode(pool, tnode, descs),
+ _pre_filter_texprs(tnode.file_scan_node.pre_filter_exprs),
+ _file_scan_node(tnode.file_scan_node) {
_output_tuple_id = tnode.file_scan_node.tuple_id;
+ LOG(WARNING) << "new file scan node";
Review Comment:
Remove log
##########
be/src/vec/exec/scan/new_file_text_scanner.cpp:
##########
@@ -45,8 +45,9 @@ Status NewFileTextScanner::open(RuntimeState* state) {
Status NewFileTextScanner::_get_block_impl(RuntimeState* state, Block* block,
bool* eof) {
SCOPED_TIMER(_read_timer);
- RETURN_IF_ERROR(init_block(block));
-
+ if (!_is_load) {
Review Comment:
No need to check `_is_load`. Because if this is for load job. the src tuple
descriptor is not null, which has already been checked in `init_block()`
##########
be/src/vec/exec/scan/new_file_scan_node.cpp:
##########
@@ -76,6 +79,7 @@ Status NewFileScanNode::_process_conjuncts() {
}
Status NewFileScanNode::_init_scanners(std::list<VScanner*>* scanners) {
+ LOG(WARNING) << "init scanners. _scan_ranges empty? " <<
_scan_ranges.empty();
Review Comment:
remove log
##########
be/src/vec/exec/scan/new_file_scan_node.cpp:
##########
@@ -92,19 +96,20 @@ Status
NewFileScanNode::_init_scanners(std::list<VScanner*>* scanners) {
VScanner* NewFileScanNode::_create_scanner(const TFileScanRange& scan_range) {
NewFileScanner* scanner = nullptr;
+ LOG(WARNING) << "format type " << scan_range.params.format_type;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
