gavinchou commented on code in PR #54623:
URL: https://github.com/apache/doris/pull/54623#discussion_r2288852720
##########
cloud/src/recycler/checker.cpp:
##########
@@ -1758,4 +1766,141 @@ int InstanceChecker::do_mow_job_key_check() {
return 0;
}
+int InstanceChecker::check_meta_rowset_key(std::string& start_key, const
std::string& end_key) {
+ return scan_and_handle_kv(
+ start_key, end_key, [&](std::string_view key, std::string_view
value) -> int {
+ RowsetMetaCloudPB meta_rowset_pb;
+ if (!meta_rowset_pb.ParseFromArray(value.data(),
value.size())) {
+ LOG(WARNING) << "failed to parse RowsetMetaCloudPB";
+ return -1;
+ }
+ std::string tablet_index_key =
+ meta_tablet_idx_key({instance_id_,
meta_rowset_pb.tablet_id()});
+ if (key_exist(txn_kv_.get(), tablet_index_key) == 1) {
+ LOG(WARNING) << "rowset's tablet id not found in fdb"
+ << "tablet_index_key: " << tablet_index_key
+ << "rowset meta: " <<
meta_rowset_pb.ShortDebugString();
+ return 1;
+ }
+ return 0;
+ });
+ return 0;
Review Comment:
seems redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
