morrySnow commented on code in PR #12475:
URL: https://github.com/apache/doris/pull/12475#discussion_r966675954


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -471,9 +471,18 @@ public PlanFragment visitPhysicalHashJoin(
                 rightChildOutputTupleDesc != null ? rightChildOutputTupleDesc 
: context.getTupleDesc(rightPlanRoot);
         TupleDescriptor outputDescriptor = context.generateTupleDesc();
         Map<ExprId, SlotReference> slotReferenceMap = Maps.newHashMap();
-        hashJoin.getOutput().stream()
-                .map(SlotReference.class::cast)
-                .forEach(s -> slotReferenceMap.put(s.getExprId(), s));
+
+        if (hashJoin.getOtherJoinCondition().isPresent()) {

Review Comment:
   we need to distinguish between intermediate tuple and output tuple. just 
intermediate tuple need expand slot to both side of child. output tuple should 
follow the original logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to