dataroaring commented on code in PR #53908:
URL: https://github.com/apache/doris/pull/53908#discussion_r2285418551
##########
be/src/cloud/cloud_tablet.cpp:
##########
@@ -1213,14 +1214,38 @@ Status CloudTablet::calc_delete_bitmap_for_compaction(
}
// 3. store delete bitmap
- auto st = _engine.meta_mgr().update_delete_bitmap(*this, -1, initiator,
-
output_rowset_delete_bitmap.get());
+ DeleteBitmapPtr delete_bitmap_v2 =
std::make_shared<DeleteBitmap>(*output_rowset_delete_bitmap);
+ auto delete_bitmap_size =
output_rowset_delete_bitmap->delete_bitmap.size();
+ if (config::delete_bitmap_store_version >= 2) {
+ std::vector<std::pair<RowsetId, int64_t>> pre_rowsets_to_segment_num;
Review Comment:
retained_rowset is a better name than pre_rowsets_to_segment_num.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
