HappenLee commented on code in PR #54957:
URL: https://github.com/apache/doris/pull/54957#discussion_r2285030416
##########
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h:
##########
@@ -137,7 +167,66 @@ class BaseTextLineReaderContext : public
TextLineReaderContextIf {
}
// Process remaining bytes
+ return find_lf_crlf_line_sep_scalar(start, length, i);
+ }
+#elif defined(__ARM_FEATURE_SVE)
+ const uint8_t* find_lf_crlf_line_sep_sve(const uint8_t* start, const
size_t length, size_t& i) {
+ const svuint8_t newline_vec = svdup_n_u8('\n');
+ const size_t vl = svcntb();
+ const svbool_t all_true = svptrue_b8();
+
+ for (; i + vl <= length; i += vl) {
Review Comment:
`i + vl == length` maybe cause memory access out-of-bounds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
