BiteTheDDDDt commented on code in PR #54875:
URL: https://github.com/apache/doris/pull/54875#discussion_r2281255864
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java:
##########
@@ -2009,9 +2009,9 @@ private List<PhysicalHashAggregate<? extends Plan>>
fourPhaseAggregateWithDistin
if (expr instanceof AggregateFunction) {
AggregateFunction aggregateFunction =
(AggregateFunction) expr;
if (aggregateFunction.isDistinct()) {
- Set<Expression> aggChild =
Sets.newLinkedHashSet(aggregateFunction.children());
- Preconditions.checkArgument(aggChild.size() ==
1
- ||
aggregateFunction.getDistinctArguments().size() == 1,
+ List<Expression> aggChild =
aggregateFunction.children();
+ Preconditions.checkArgument(new
HashSet<>(aggChild).size() == 1
Review Comment:
Yes, the main purpose of this PR is to prevent pass wrong child to the
function and provides clear error messages when not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
