gavinchou commented on code in PR #54912:
URL: https://github.com/apache/doris/pull/54912#discussion_r2280781770
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1328,6 +1328,12 @@ void
MetaServiceImpl::prepare_restore_job(::google::protobuf::RpcController* con
RestoreJobResponse* response,
::google::protobuf::Closure* done) {
RPC_PREPROCESS(prepare_restore_job);
+ if (request->action() != RestoreJobRequest::PREPARE) {
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ msg = "invalid action";
Review Comment:
the error msg should tell what action is expected and what action is given
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
