HappenLee commented on code in PR #54638:
URL: https://github.com/apache/doris/pull/54638#discussion_r2278189322
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -313,6 +318,38 @@ public boolean isTemporaryPartition(long partitionId) {
return tempPartitions.hasPartition(partitionId);
}
+ /**
+ * Acquire a future representing the in-flight creation task for the given
partition name.
+ * If no task exists, create and register a new one and return it with
ownership=true.
+ * If a task already exists, return the existing one with ownership=false.
+ */
+ public Pair<CompletableFuture<Void>, Boolean>
acquirePartitionCreationFuture(String partitionName) {
+ CompletableFuture<Void> newFuture = new CompletableFuture<>();
+ CompletableFuture<Void> existing =
partitionCreationFutures.putIfAbsent(partitionName, newFuture);
+ if (existing == null) {
+ return Pair.of(newFuture, true);
+ } else {
+ return Pair.of(existing, false);
+ }
+ }
+
+ /**
+ * Complete and unregister the partition creation future. If t is null,
complete normally,
+ * otherwise complete exceptionally. Removal uses (key, value) to avoid
removing a new future
+ * that might have been installed after this one completed.
+ */
+ public void completePartitionCreationFuture(String partitionName,
CompletableFuture<Void> future, Throwable t) {
+ try {
+ if (t == null) {
+ future.complete(null);
+ } else {
+ future.completeExceptionally(t);
+ }
+ } finally {
+ partitionCreationFutures.remove(partitionName, future);
Review Comment:
may deadlock if you complete and after remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
