cambyzju commented on code in PR #12424:
URL: https://github.com/apache/doris/pull/12424#discussion_r964713303
##########
be/src/exec/base_scanner.cpp:
##########
@@ -481,4 +481,35 @@ void BaseScanner::_fill_columns_from_path() {
}
}
+bool BaseScanner::is_null(const Slice& slice) {
+ return slice.size == 2 && slice.data[0] == '\\' && slice.data[1] == 'N';
+}
+
+bool BaseScanner::is_array(const Slice& slice) {
+ return slice.size > 0 && slice.data[0] == '[' && slice.data[slice.size -
1] == ']';
Review Comment:
```suggestion
return slice.size > 1 && slice.data[0] == '[' && slice.data[slice.size -
1] == ']';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
