morrySnow commented on code in PR #12416:
URL: https://github.com/apache/doris/pull/12416#discussion_r964617443
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java:
##########
@@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos) {
@Override
public DataType getDataType() {
- return StringType.INSTANCE;
+ return VarcharType.SYSTEM_DEFAULT;
Review Comment:
if be can obtain length, so optimize in runtime could be used. Such as low
cardinality optimization in building hash table
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java:
##########
@@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos) {
@Override
public DataType getDataType() {
- return StringType.INSTANCE;
+ return VarcharType.SYSTEM_DEFAULT;
Review Comment:
if be can obtain length, some optimize in runtime could be used. Such as low
cardinality optimization in building hash table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
