This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 8accbc30beb branch-3.0: [fix](prepare statement)Use client prepare
statement when placeholders are more than 65536. (#54568) (#54668)
8accbc30beb is described below
commit 8accbc30beb1c55eabb8fe272385eae9aab4ede8
Author: James <[email protected]>
AuthorDate: Thu Aug 14 11:52:18 2025 +0800
branch-3.0: [fix](prepare statement)Use client prepare statement when
placeholders are more than 65536. (#54568) (#54668)
https://github.com/apache/doris/pull/54568
---
.../doris/nereids/trees/plans/commands/PrepareCommand.java | 6 ++++++
regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy | 12 +++++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/PrepareCommand.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/PrepareCommand.java
index 42274c5eaf8..b418e7d211a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/PrepareCommand.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/PrepareCommand.java
@@ -18,6 +18,8 @@
package org.apache.doris.nereids.trees.plans.commands;
import org.apache.doris.analysis.StmtType;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
import org.apache.doris.mysql.MysqlCommand;
import org.apache.doris.nereids.trees.expressions.Placeholder;
import org.apache.doris.nereids.trees.plans.PlanType;
@@ -43,6 +45,7 @@ public class PrepareCommand extends Command {
private final List<Placeholder> placeholders = new ArrayList<>();
private final LogicalPlan logicalPlan;
+ private final int maxPlaceholderCount = 65536;
private final String name;
@@ -99,6 +102,9 @@ public class PrepareCommand extends Command {
@Override
public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
List<String> labels = getLabels();
+ if (labels.size() >= maxPlaceholderCount) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_PS_MANY_PARAM);
+ }
// register prepareStmt
if (LOG.isDebugEnabled()) {
LOG.debug("add prepared statement {}, isBinaryProtocol {}",
diff --git a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
index 353b4b4552f..80058e72894 100644
--- a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
+++ b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
@@ -63,7 +63,17 @@ suite("test_prepared_stmt", "nonConcurrent") {
sql "set enable_fallback_to_original_planner = false"
sql """set global enable_server_side_prepared_statement = true"""
- def stmt_read = prepareStatement "select * from ${tableName} where k1
= ? order by k1"
+ int count = 65536;
+ StringBuilder sb = new StringBuilder();
+ sb.append("?");
+ for (int i = 1; i < count; i++) {
+ sb.append(", ?");
+ }
+ String sqlWithTooManyPlaceholder = sb.toString();
+ def stmt_read = prepareStatement "select * from ${tableName} where k1
in ${sqlWithTooManyPlaceholder}"
+ assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
+
+ stmt_read = prepareStatement "select * from ${tableName} where k1 = ?
order by k1"
assertEquals(com.mysql.cj.jdbc.ServerPreparedStatement,
stmt_read.class)
stmt_read.setInt(1, 1231)
qe_select0 stmt_read
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
