cambyzju commented on code in PR #12404: URL: https://github.com/apache/doris/pull/12404#discussion_r964371039
########## be/src/vec/columns/column_vector.h: ########## @@ -288,6 +288,12 @@ class ColumnVector final : public COWHelper<ColumnVectorHelper, ColumnVector<T>> } } + void set_all_to_zero(size_t num) { + for (size_t i = 0; i < num; ++i) { Review Comment: may be use memset is better for performance: `memset(data.data(), 0, sizeof(value_type) * num);` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org