jackwener commented on code in PR #12391:
URL: https://github.com/apache/doris/pull/12391#discussion_r963826374
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -378,8 +379,16 @@ public PlanFragment
visitPhysicalHashJoin(PhysicalHashJoin<Plan, Plan> hashJoin,
.map(e -> ExpressionTranslator.translate(e, context))
.collect(Collectors.toList());
+ List<Expr> otherJoinConjuncts = hashJoin.getOtherJoinCondition()
+ .map(ExpressionUtils::extractConjunction)
+ .orElseGet(Lists::newArrayList)
+ .stream()
+ .filter(e -> !(e.equals(BooleanLiteral.TRUE)))
Review Comment:
> do we have to consider const conjuncts here? `TRUE` is a special case of
const conjunct. There are some other conjucts, like `1=1` or `FALSE`. I think
there should be a rule to clean them before translate. So I think we do not
need to filter them here.
It's should be consider by other rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
