englefly commented on code in PR #12374:
URL: https://github.com/apache/doris/pull/12374#discussion_r963808216
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Year.java:
##########
@@ -53,7 +53,7 @@ public DataType getDataType() {
@Override
public boolean nullable() {
Review Comment:
`WeekOfYear` is the same. Could u update it in this pr.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Divide.java:
##########
@@ -50,4 +51,9 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C
context) {
public AbstractDataType inputType() {
return NumericType.INSTANCE;
}
+
+ @Override
+ public boolean nullable() throws UnboundException {
+ return true;
Review Comment:
Could u add some comments to explain why it is nullable? I guess the reason
is some string cannot be cast to date type. If this is true all date related
functions are nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
