HappenLee commented on code in PR #12334:
URL: https://github.com/apache/doris/pull/12334#discussion_r963433648
##########
be/src/vec/columns/column.h:
##########
@@ -286,6 +299,12 @@ class IColumn : public COW<IColumn> {
/// passed bytes to hash must identify sequence of values unambiguously.
virtual void update_hash_with_value(size_t n, SipHash& hash) const = 0;
+ /// Update state of hash function with value of n elements to avoid the
virtual function call
+ /// null_data to mark whether need to do hash compute, null_data == nullptr
+ /// means all element need to do hash function, else only *null_data != 0
need to do hash func
+ virtual void update_hashes_with_value(std::vector<SipHash>& hash,
Review Comment:
I rethink. @cambyzju you are right. we need to make the code more clean to
do not use the pure virtual function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
