cambyzju commented on code in PR #12321: URL: https://github.com/apache/doris/pull/12321#discussion_r963213058
########## be/src/vec/functions/function_string.h: ########## @@ -494,6 +494,51 @@ class FunctionStringConcat : public IFunction { } }; +class FunctionStringElt : public IFunction { +public: + static constexpr auto name = "elt"; + static FunctionPtr create() { return std::make_shared<FunctionStringElt>(); } + String get_name() const override { return name; } + size_t get_number_of_arguments() const override { return 0; } + bool is_variadic() const override { return true; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeString>(); Review Comment: need check arguments size >= 2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org