freemandealer opened a new pull request, #12362:
URL: https://github.com/apache/doris/pull/12362

   Each NodeChannel has its own queue, with size up to 1/20 exec_mem_limit.
   User will crash into OOM if set exec_mem_limit high. This commit uses
   fixed number to control the total max memory used by NodeChannels.
   
   Signed-off-by: freemandealer <freeman.zhang1...@gmail.com>
   
   # Proposed changes
   
   Issue Number: close #12359
   
   ## Problem summary
   FIx OOM caused by pending queues
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [x] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   performance test result:
   
   Before:
   streamload 100 concurrent job  |    13~27s   finish time    | 14.2% memory 
consumption
   s3load        100 concurrent job   |    4~9min     | 55%
   
   After:
   streamload 100 concurrent job  |    5~20s       | 21% memory consumption
   s3load        100 concurrent job   |    5~7m30s | 40%
   
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to