eldenmoon commented on code in PR #12293: URL: https://github.com/apache/doris/pull/12293#discussion_r962868057
########## be/src/common/config.h: ########## @@ -849,6 +849,8 @@ CONF_Bool(enable_simdjson_reader, "false"); CONF_Int32(doris_remote_scanner_thread_pool_thread_num, "16"); // number of s3 scanner thread pool queue size CONF_Int32(doris_remote_scanner_thread_pool_queue_size, "10240"); +// write offsets instead of length to speed up seek performance +CONF_Bool(enable_write_array_offset, "false"); Review Comment: 1. the code provided both backward and forward compability, use `_length_iterator->get_current_page()->next_array_item_ordinal > 0` to distinguish whether we go the offset path else length path 2. I think delete row is not effected whether using offset or length, it's re compacted and written a new column? 3. clickhous store array offset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
