zy-kkk opened a new pull request, #54519:
URL: https://github.com/apache/doris/pull/54519
This PR fixes compilation issues on macOS when Precompiled Headers (PCH)
are disabled. The changes include:
Key fixes:
- Add _DARWIN_C_SOURCE macro definition for macOS to enable system headers
like INADDR_NONE
- Include necessary system headers (netinet/in.h, sys/_types/_u_int.h) for
macOS compatibility
- Add missing <sstream> header for std::ostringstream usage
- Fix implicit type conversion warnings in wide integer implementation
Changes:
- Updated CMakeLists.txt with macOS-specific definitions
- Added system header includes in dependency.h for macOS
- Fixed missing header includes in wide_integer.h
- Added explicit type casting to resolve precision warnings
This ensures the codebase compiles correctly on macOS regardless of PCH
settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
