This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new a473a238985 branch-21: [improve](udf) let create udf function error
msg more clear (#54202) (#54283)
a473a238985 is described below
commit a473a238985aa086cfc4030c26d0024d0884345c
Author: zhangstar333 <[email protected]>
AuthorDate: Fri Aug 8 09:55:32 2025 +0800
branch-21: [improve](udf) let create udf function error msg more clear
(#54202) (#54283)
### What problem does this PR solve?
Problem Summary:
cherry-pick from master (#54202)
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
.../org/apache/doris/analysis/CreateFunctionStmt.java | 18 +++++++++++-------
.../suites/javaudf_p0/test_javaudf_int.groovy | 10 ++++++++++
2 files changed, 21 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
index 3db95cb6a9f..d954cc5d3a3 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
@@ -591,8 +591,10 @@ public class CreateFunctionStmt extends DdlStmt {
m -> m.getParameters().length ==
argsDef.getArgTypes().length).collect(Collectors.toList());
if (evalArgLengthMatchList.size() == 0) {
throw new AnalysisException(
- String.format("The number of parameters for method '%s' in
class '%s' should be %d",
- EVAL_METHOD_KEY, udfClass.getCanonicalName(),
argsDef.getArgTypes().length));
+ String.format(
+ "The arguments number udf provided and create
function command is not equal,"
+ + " the parameters of '%s' method in class
'%s' maybe should %d.",
+ EVAL_METHOD_KEY, udfClass.getCanonicalName(),
argsDef.getArgTypes().length));
} else if (evalArgLengthMatchList.size() == 1) {
Method method = evalArgLengthMatchList.get(0);
checkUdfType(udfClass, method, returnType.getType(),
method.getReturnType(), "return");
@@ -639,19 +641,21 @@ public class CreateFunctionStmt extends DdlStmt {
javaTypes =
Type.PrimitiveTypeToJavaClassType.get(mapType.getPrimitiveType());
} else {
throw new AnalysisException(
- String.format("Method '%s' in class '%s' does not support
type '%s'",
+ String.format("Method '%s' in class '%s' does not support
type '%s'.",
method.getName(), clazz.getCanonicalName(),
expType));
}
if (javaTypes == null) {
throw new AnalysisException(
- String.format("Method '%s' in class '%s' does not support
type '%s'",
- method.getName(), clazz.getCanonicalName(),
expType.toString()));
+ String.format("Method '%s' in class '%s' does not support
type '%s'.",
+ method.getName(), clazz.getCanonicalName(),
expType.getPrimitiveType().toString()));
}
if (!javaTypes.contains(pType)) {
throw new AnalysisException(
- String.format("UDF class '%s' method '%s' %s[%s] type is
not supported!",
- clazz.getCanonicalName(), method.getName(), pname,
pType.getCanonicalName()));
+ String.format(
+ "UDF class '%s' of method '%s' %s is [%s] type,
but create function command type is %s.",
+ clazz.getCanonicalName(), method.getName(), pname,
pType.getCanonicalName(),
+ expType.getPrimitiveType().toString()));
}
}
diff --git a/regression-test/suites/javaudf_p0/test_javaudf_int.groovy
b/regression-test/suites/javaudf_p0/test_javaudf_int.groovy
index 7433866a9f2..9b4ddd0b3e2 100644
--- a/regression-test/suites/javaudf_p0/test_javaudf_int.groovy
+++ b/regression-test/suites/javaudf_p0/test_javaudf_int.groovy
@@ -147,6 +147,16 @@ suite("test_javaudf_int") {
exception "but the return type is not nullable"
}
+ test {
+ sql """ CREATE FUNCTION
java_udf_largeint_test_not_nullable(largeint) RETURNS string PROPERTIES (
+ "file"="file://${jarPath}",
+ "symbol"="org.apache.doris.udf.LargeintTest",
+ "always_nullable"="false",
+ "type"="JAVA_UDF"
+ ); """
+ exception "but create function command type is STRING"
+ }
+
} finally {
try_sql("DROP GLOBAL FUNCTION IF EXISTS
java_udf_int_test_global(int);")
try_sql("DROP FUNCTION IF EXISTS java_udf_tinyint_test(tinyint);")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
