CalvinKirs opened a new pull request, #54300:
URL: https://github.com/apache/doris/pull/54300

   #50238 
   
   ### PR Description
   This PR fixes a special case where the endpoint parameter might be missing 
when using DLF as the Hive Metastore (MS) without configuring any storage 
backend.
   
   #### Background
   In certain deployments, users rely solely on DLF as the metastore and do not 
explicitly configure object storage credentials. In these cases:
   
   Only DLF access_key, secret_key, and region are provided.
   
   dlf.endpoint is omitted by the user.
   
   The system attempts to initialize storage configuration, but fails because 
endpoint is required.
   
   This issue occurs because the existing logic assumes that the storage module 
always receives a valid endpoint, which is not the case when DLF is used as MS 
only.
   
   #### Fix
   When dlf.endpoint is not set, and dlf.region is available, this patch 
automatically derives a valid default endpoint based on the region and network 
mode (public or VPC).
   
   This logic is consistent with the existing behavior of DLF SDKs and avoids 
unnecessary configuration burden for users using DLF as MS only.
   
   #### Compatibility
   Backward compatible: No breaking change for users who already provide an 
endpoint.
   
   Recommended best practice remains: Users are encouraged to explicitly 
configure both endpoint and region for clarity.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to