vinlee19 commented on code in PR #54043:
URL: https://github.com/apache/doris/pull/54043#discussion_r2242625347
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonUtil.java:
##########
@@ -116,12 +117,23 @@ public static PaimonPartitionInfo
generatePartitionInfo(List<Column> partitionCo
Map<String, PartitionItem> nameToPartitionItem = Maps.newHashMap();
Map<String, Partition> nameToPartition = Maps.newHashMap();
PaimonPartitionInfo partitionInfo = new
PaimonPartitionInfo(nameToPartitionItem, nameToPartition);
+ List<Type> types = partitionColumns.stream()
+ .map(Column::getType)
+ .collect(Collectors.toList());
for (Partition partition : paimonPartitions) {
+ int index = 0;
Review Comment:
After careful consideration, a better approach would be to create a
name-to-type mapping from partitionColumns, then look up the type directly by
column name when iterating through partition.spec(). This eliminates the
dependency on index-based matching and makes the code more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]