englefly commented on code in PR #12113: URL: https://github.com/apache/doris/pull/12113#discussion_r957939882
########## fe/fe-core/src/main/java/org/apache/doris/analysis/FromClause.java: ########## @@ -44,6 +46,8 @@ public class FromClause implements ParseNode, Iterable<TableRef> { private boolean analyzed = false; private boolean needToSql = false; + private final Map<Integer, TableRef> tableRefPositions = new HashMap<Integer, TableRef>(); Review Comment: it would be better if we use a list instead of Map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org