yujun777 commented on code in PR #53835:
URL: https://github.com/apache/doris/pull/53835#discussion_r2239093543


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionNormalization.java:
##########
@@ -63,6 +65,8 @@ public class ExpressionNormalization extends 
ExpressionRewrite {
                 ConvertAggStateCast.INSTANCE,
                 MergeDateTrunc.INSTANCE,
                 JsonFunctionRewrite.INSTANCE,
+                LogToLn.INSTANCE,

Review Comment:
   in ExpressionNormalization,  for the rule order,  LogToIn  is follow 
FoldConstantRule,  then for expression log(100),  why apply LogToIn first then 
FoldConstantRule,  will the order be stable ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to