924060929 opened a new pull request, #12147: URL: https://github.com/apache/doris/pull/12147
# Proposed changes refactor `memo.copyIn` to all rewrite case It the past, `memo.copyIn` has complex logic to process init, rewrite and copyIn, It's difficult to understand and easy to meet bug and leak memory for some unreachable group/groupExpression. So I separate it into three methods: 1. `Memo.init` for init Memo by LogicalPlan 2. `Memo.rewrite` for rewrite 3. `Memo.copyIn` for exploration and implementation And add a lots of UT for `Memo.rewrite`. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 4. Has unit tests been added: - [x] Yes - [ ] No - [ ] No Need 5. Has document been added or modified: - [ ] Yes - [ ] No - [x] No Need 6. Does it need to update dependencies: - [ ] Yes - [x] No 7. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org