gavinchou commented on code in PR #53866:
URL: https://github.com/apache/doris/pull/53866#discussion_r2235468523
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -1543,49 +1543,19 @@ int InstanceRecycler::recycle_tablets(int64_t table_id,
int64_t index_id,
}
tablet_idx_keys.push_back(meta_tablet_idx_key({instance_id_,
tablet_id}));
- if (!is_empty_tablet) {
- sync_executor.add([this, &num_recycled, tid = tablet_id,
range_move = use_range_remove,
- &metrics_context, k]() mutable -> TabletKeyPair
{
- if (recycle_tablet(tid, metrics_context) != 0) {
- LOG_WARNING("failed to recycle tablet")
- .tag("instance_id", instance_id_)
- .tag("tablet_id", tid);
- range_move = false;
- return {std::string_view(), range_move};
- }
- ++num_recycled;
- LOG(INFO) << "recycle_tablets scan, key=" << (k.empty() ?
"(empty)" : hex(k));
- return {k, range_move};
- });
- } else {
- // Empty tablet only has a [0-1] init rowset
- init_rs_keys.push_back(meta_rowset_key({instance_id_, tablet_id,
1}));
- DCHECK([&]() {
- std::unique_ptr<Transaction> txn;
- if (TxnErrorCode err = txn_kv_->create_txn(&txn); err !=
TxnErrorCode::TXN_OK) {
- LOG_ERROR("failed to create txn").tag("err", err);
- return false;
- }
- auto rs_key_begin = meta_rowset_key({instance_id_, tablet_id,
2});
- auto rs_key_end = meta_rowset_key({instance_id_, tablet_id,
INT64_MAX});
- std::unique_ptr<RangeGetIterator> iter;
- if (TxnErrorCode err = txn->get(rs_key_begin, rs_key_end,
&iter, true, 1);
- err != TxnErrorCode::TXN_OK) {
- LOG_ERROR("failed to get kv").tag("err", err);
- return false;
- }
- if (iter->has_next()) {
- LOG_ERROR("tablet is not empty").tag("tablet_id",
tablet_id);
- return false;
- }
- return true;
- }());
- sync_executor.add([k]() mutable -> TabletKeyPair {
- LOG_INFO("k is {}, is empty {}", k, k.empty());
- return {k, true};
- });
+ sync_executor.add([this, &num_recycled, tid = tablet_id, range_move =
use_range_remove,
Review Comment:
need to be discussed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
