amorynan commented on code in PR #53923: URL: https://github.com/apache/doris/pull/53923#discussion_r2234809513
########## be/src/vec/json/parse2column.cpp: ########## @@ -155,6 +155,14 @@ void parse_json_to_variant(IColumn& column, const char* src, size_t length, auto& [paths, values] = *result; assert(paths.size() == values.size()); size_t old_num_rows = column_variant.size(); + // here we should check the paths in variant and paths in result, + // if two paths which same prefix have different structure, we should throw an exception + std::vector<PathInData> check_paths; Review Comment: done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org