[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11842: [feature](planner) Column prune for nereids

[GitBox]

Kikyou1997 commented on code in PR #11842:
URL: https://github.com/apache/doris/pull/11842#discussion_r956611126


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PlanTranslatorContext.java:
##########
@@ -110,23 +113,25 @@ public SlotDescriptor createSlotDesc(TupleDescriptor 
tupleDesc, SlotReference sl
         }
         
slotDescriptor.setType(slotReference.getDataType().toCatalogDataType());
         slotDescriptor.setIsMaterialized(true);
+        slotDescriptor.setIsNullable(slotReference.nullable());
         this.addExprIdPair(slotReference.getExprId(), new 
SlotRef(slotDescriptor));
         return slotDescriptor;
     }
 
-    /**
-     * Create slotDesc with Expression.
-     */
-    public void createSlotDesc(TupleDescriptor tupleDesc, Expression 
expression) {
-        SlotDescriptor slotDescriptor = this.addSlotDesc(tupleDesc);
-        slotDescriptor.setType(expression.getDataType().toCatalogDataType());
-    }
-
     public TupleDescriptor getTupleDesc(TupleId tupleId) {
         return descTable.getTupleDesc(tupleId);
     }
 
     public DescriptorTable getDescTable() {
         return descTable;
     }
+
+    public void putPlanToExprIdMapping(PhysicalPlan plan, Set<ExprId> exprId) {
+        requiredSlotOfEachPhysicalOperator.put(plan, exprId);
+    }
+
+    public Set<ExprId> getRequiredExprId(PhysicalPlan plan) {
+        return requiredSlotOfEachPhysicalOperator.get(plan);
+    }

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org