adonis0147 commented on code in PR #12127:
URL: https://github.com/apache/doris/pull/12127#discussion_r956601868
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/EqualTo.java:
##########
@@ -33,6 +33,10 @@ public EqualTo(Expression left, Expression right) {
super(left, right, "=");
}
+ public static EqualTo of(Expression left, Expression right) {
Review Comment:
I think it is not evil to use `new` to instantiate an object. JVM may not
always inline some methods. An extra wrapper method which just passes argument
to `new` only may introduce some unnecessary costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
