dataroaring commented on code in PR #12117:
URL: https://github.com/apache/doris/pull/12117#discussion_r956558085


##########
be/src/exec/olap_scanner.cpp:
##########
@@ -152,14 +152,15 @@ Status OlapScanner::_init_tablet_reader_params(
                       ->rowset()
                       ->rowset_meta()
                       ->is_segments_overlapping());
+    
+    bool has_replace_col = false;
+    RETURN_IF_ERROR(_init_return_columns(!single_non_overlapping_version, 
has_replace_col));
 
-    _tablet_reader_params.direct_mode = single_version || _aggregation;

Review Comment:
   I am not sure what we need to in planner.  If fe sets aggregation, we ignore 
it here, then we can ignore aggreagate in planner somtimes?  Could you throw an 
example sql?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to