morningman commented on code in PR #53729:
URL: https://github.com/apache/doris/pull/53729#discussion_r2230040642
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -443,10 +442,13 @@ Status NewJsonReader::_open_file_reader(bool need_schema)
{
_file_description.mtime = _range.__isset.modification_time ?
_range.modification_time : 0;
io::FileReaderOptions reader_options =
FileFactory::get_reader_options(_state, _file_description);
- _file_reader = DORIS_TRY(io::DelegateReader::create_file_reader(
+ auto file_reader = DORIS_TRY(io::DelegateReader::create_file_reader(
_profile, _system_properties, _file_description,
reader_options,
io::DelegateReader::AccessMode::SEQUENTIAL, _io_ctx,
io::PrefetchRange(_range.start_offset, _range.size)));
+ _file_reader = _io_ctx ?
std::make_shared<io::TracingFileReader>(std::move(file_reader),
Review Comment:
How about move this check into `io::DelegateReader::create_file_reader`?
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -829,14 +829,14 @@ class ORCFileInputStream : public orc::InputStream,
public ProfileCollector {
const std::string& _file_name;
io::FileReaderSPtr _inner_reader;
io::FileReaderSPtr _file_reader;
+ io::FileReaderSPtr _tracing_file_reader;
Review Comment:
There are too many file readers here, I think we should add some comment.
##########
be/src/vec/exec/format/parquet/vparquet_reader.h:
##########
@@ -253,6 +252,7 @@ class ParquetReader : public GenericReader {
const tparquet::FileMetaData* _t_metadata = nullptr;
io::FileReaderSPtr _file_reader = nullptr;
+ io::FileReaderSPtr _tracing_file_reader = nullptr;
Review Comment:
Add some comments to explain the relation of these file readers
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -120,6 +121,11 @@ ParquetReader::~ParquetReader() {
_close_internal();
}
+void ParquetReader::set_file_reader(io::FileReaderSPtr file_reader) {
+ _file_reader = file_reader;
+ _tracing_file_reader = file_reader;
Review Comment:
Why need 2 file reader point to the same object?
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1127,8 +1113,10 @@ Status OrcReader::set_fill_columns(
orc_input_stream_ptr->set_all_tiny_stripes();
auto& orc_file_reader =
orc_input_stream_ptr->get_file_reader();
auto orc_inner_reader =
orc_input_stream_ptr->get_inner_reader();
- orc_file_reader = std::make_shared<io::RangeCacheFileReader>(
- _profile, orc_inner_reader, range_finder);
+ orc_file_reader = std::make_shared<io::TracingFileReader>(
+ std::make_shared<io::RangeCacheFileReader>(_profile,
orc_inner_reader,
+
range_finder),
+ _io_ctx->file_reader_stats);
Review Comment:
how to make sure the `_io_ctx` is not nullptr?
Because you check this in `get_next_block()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
