[GitHub] [doris] morningman commented on a diff in pull request #12106: [refactor](BE) return error status when vslot_ref contains invalid slot_id

[GitBox]

morningman commented on code in PR #12106:
URL: https://github.com/apache/doris/pull/12106#discussion_r956231934


##########
be/src/vec/exprs/vslot_ref.cpp:
##########
@@ -51,16 +51,16 @@ Status VSlotRef::prepare(doris::RuntimeState* state, const 
doris::RowDescriptor&
         return Status::InternalError("couldn't resolve slot descriptor {}", 
_slot_id);
     }
     _column_id = desc.get_column_id(_slot_id);
+    if (_column_id < 0) {
+        LOG(INFO) << "VSlotRef - invalid slot id " << _slot_id;
+        LOG(INFO) << desc.debug_string();

Review Comment:
   Better print in one line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org