morrySnow commented on code in PR #53632:
URL: https://github.com/apache/doris/pull/53632#discussion_r2228225402
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionNormalization.java:
##########
@@ -40,26 +41,26 @@
* normalize expression of plan rule set.
*/
public class ExpressionNormalization extends ExpressionRewrite {
- // we should run supportJavaDateFormatter before foldConstantRule or be
will fold
+ // we should run supportJavaDateFormatter before foldConstantRule or be
will
+ // fold
// from_unixtime(timestamp, 'yyyyMMdd') to 'yyyyMMdd'
public static final List<ExpressionRewriteRule> NORMALIZE_REWRITE_RULES =
ImmutableList.of(
bottomUp(
- SupportJavaDateFormatter.INSTANCE,
- NormalizeBinaryPredicatesRule.INSTANCE,
- InPredicateDedup.INSTANCE,
- InPredicateExtractNonConstant.INSTANCE,
- InPredicateToEqualToRule.INSTANCE,
- SimplifyNotExprRule.INSTANCE,
- SimplifyArithmeticRule.INSTANCE,
- FoldConstantRule.INSTANCE,
- SimplifyCastRule.INSTANCE,
- DigitalMaskingConvert.INSTANCE,
- SimplifyArithmeticComparisonRule.INSTANCE,
- ConvertAggStateCast.INSTANCE,
- MergeDateTrunc.INSTANCE,
- CheckCast.INSTANCE
- )
- );
+ SupportJavaDateFormatter.INSTANCE,
+ NormalizeBinaryPredicatesRule.INSTANCE,
+ InPredicateDedup.INSTANCE,
+ InPredicateExtractNonConstant.INSTANCE,
+ InPredicateToEqualToRule.INSTANCE,
+ SimplifyNotExprRule.INSTANCE,
+ SimplifyArithmeticRule.INSTANCE,
+ FoldConstantRule.INSTANCE,
+ SimplifyCastRule.INSTANCE,
+ DigitalMaskingConvert.INSTANCE,
+ SimplifyArithmeticComparisonRule.INSTANCE,
+ ConvertAggStateCast.INSTANCE,
Review Comment:
do not change the order
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java:
##########
@@ -43,29 +42,24 @@
public class ExpressionOptimization extends ExpressionRewrite {
public static final List<ExpressionRewriteRule> OPTIMIZE_REWRITE_RULES =
ImmutableList.of(
bottomUp(
- SimplifyInPredicate.INSTANCE,
+ SimplifyInPredicate.INSTANCE,
- // comparison predicates
- SimplifyComparisonPredicate.INSTANCE,
+ // comparison predicates
+ SimplifyComparisonPredicate.INSTANCE,
- // compound predicates
- SimplifyRange.INSTANCE,
- SimplifyConflictCompound.INSTANCE,
- DistinctPredicatesRule.INSTANCE,
- ExtractCommonFactorRule.INSTANCE,
-
- SimplifyDecimalV3Comparison.INSTANCE,
-
- DateFunctionRewrite.INSTANCE,
- ArrayContainToArrayOverlap.INSTANCE,
- CaseWhenToIf.INSTANCE,
- TopnToMax.INSTANCE,
- NullSafeEqualToEqual.INSTANCE,
- LikeToEqualRewrite.INSTANCE,
- BetweenToEqual.INSTANCE,
- LogToLn.INSTANCE
- )
- );
+ // compound predicates
+ SimplifyRange.INSTANCE,
+ SimplifyConflictCompound.INSTANCE,
+ DistinctPredicatesRule.INSTANCE,
+ ExtractCommonFactorRule.INSTANCE,
+ DateFunctionRewrite.INSTANCE,
Review Comment:
do not change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
