This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6fb32014e74 [fix](regression) Set `be-cluster-id` default to false
(#53643)
6fb32014e74 is described below
commit 6fb32014e743f63e9df405b6d95dd0137691a039
Author: deardeng <[email protected]>
AuthorDate: Thu Jul 24 10:57:42 2025 +0800
[fix](regression) Set `be-cluster-id` default to false (#53643)
Problem Summary:
1. --be-cluster-id set default to false
---
docker/runtime/doris-compose/command.py | 20 +++++++-------------
.../doris/regression/suite/SuiteCluster.groovy | 4 ++--
2 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/docker/runtime/doris-compose/command.py
b/docker/runtime/doris-compose/command.py
index 760dd577bcd..56ef98a89a8 100644
--- a/docker/runtime/doris-compose/command.py
+++ b/docker/runtime/doris-compose/command.py
@@ -480,19 +480,12 @@ class UpCommand(Command):
"Do not set BE meta service endpoint in conf. Default is
False."
)
- if self._support_boolean_action():
- parser.add_argument(
- "--be-cluster-id",
- default=False,
- action=self._get_parser_bool_action(False),
- help="Do not set BE cluster ID in conf. Default is False.")
- else:
- parser.add_argument(
- "--no-be-cluster-id",
- dest='be_cluster_id',
- default=False,
- action=self._get_parser_bool_action(False),
- help="Do not set BE cluster ID in conf. Default is False.")
+ # if default==False, use this style to parser, like --be-cluster-id
+ parser.add_argument(
+ "--be-cluster-id",
+ default=False,
+ action=self._get_parser_bool_action(True),
+ help="Do not set BE cluster ID in conf. Default is False.")
parser.add_argument(
"--fdb-version",
@@ -500,6 +493,7 @@ class UpCommand(Command):
default="7.1.26",
help="fdb image version. Only use in cloud cluster.")
+ # if default==True, use this style to parser, like --detach
if self._support_boolean_action():
parser.add_argument(
"--detach",
diff --git
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteCluster.groovy
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteCluster.groovy
index 12ef84c5964..8f834aa3ca4 100644
---
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteCluster.groovy
+++
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteCluster.groovy
@@ -362,8 +362,8 @@ class SuiteCluster {
if (!options.beMetaServiceEndpoint) {
cmd += ['--no-be-metaservice-endpoint']
}
- if (!options.beClusterId) {
- cmd += ['--no-be-cluster-id']
+ if (options.beClusterId) {
+ cmd += ['--be-cluster-id']
}
cmd += ['--wait-timeout', String.valueOf(options.waitTimeout)]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
