HappenLee commented on code in PR #52701: URL: https://github.com/apache/doris/pull/52701#discussion_r2225079304
########## be/src/vec/exprs/virtual_slot_ref.cpp: ########## @@ -0,0 +1,207 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exprs/virtual_slot_ref.h" + +#include <gen_cpp/Exprs_types.h> +#include <glog/logging.h> +#include <thrift/protocol/TDebugProtocol.h> + +#include <ostream> + +#include "common/exception.h" +#include "common/logging.h" +#include "common/status.h" +#include "runtime/descriptors.h" +#include "runtime/runtime_state.h" +#include "vec/columns/column.h" +#include "vec/columns/column_nothing.h" +#include "vec/core/block.h" +#include "vec/core/column_with_type_and_name.h" +#include "vec/exprs/vectorized_fn_call.h" +#include "vec/exprs/vexpr_context.h" +#include "vec/exprs/vexpr_fwd.h" + +namespace doris::vectorized { + +VirtualSlotRef::VirtualSlotRef(const doris::TExprNode& node) + : VExpr(node), + _column_id(-1), + _slot_id(node.slot_ref.slot_id), + _column_name(nullptr), + _column_label(node.label) {} + +VirtualSlotRef::VirtualSlotRef(const SlotDescriptor* desc) + : VExpr(desc->type(), false), _column_id(-1), _slot_id(desc->id()), _column_name(nullptr) {} + +Status VirtualSlotRef::prepare(doris::RuntimeState* state, const doris::RowDescriptor& desc, + VExprContext* context) { + RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context)); + DCHECK_EQ(_children.size(), 0); + if (_slot_id == -1) { + _prepare_finished = true; + return Status::OK(); + } + + const SlotDescriptor* slot_desc = state->desc_tbl().get_slot_descriptor(_slot_id); + if (slot_desc == nullptr) { + return Status::Error<ErrorCode::INTERNAL_ERROR>( + "couldn't resolve slot descriptor {}, desc: {}", _slot_id, + state->desc_tbl().debug_string()); + } + + if (slot_desc->get_virtual_column_expr() == nullptr) { + return Status::InternalError( + "VirtualSlotRef {} has no virtual column expr, slot_id: {}, desc: {}, " + "slot_desc: {}, desc_tbl: {}", + *_column_name, _slot_id, desc.debug_string(), slot_desc->debug_string(), + state->desc_tbl().debug_string()); + } + + _column_name = &slot_desc->col_name(); + _column_data_type = slot_desc->get_data_type_ptr(); + DCHECK(_column_data_type != nullptr); + if (!context->force_materialize_slot() && !slot_desc->is_materialized()) { + // slot should be ignored manually + _column_id = -1; + _prepare_finished = true; + return Status::OK(); + } + + _column_id = desc.get_column_id(_slot_id, context->force_materialize_slot()); + if (_column_id < 0) { + return Status::Error<ErrorCode::INTERNAL_ERROR>( + "VirtualSlotRef {} has invalid slot id: " + "{}.\nslot_desc:\n{},\ndesc:\n{},\ndesc_tbl:\n{}", + *_column_name, _slot_id, slot_desc->debug_string(), desc.debug_string(), + state->desc_tbl().debug_string()); + } + const TExpr& expr = *slot_desc->get_virtual_column_expr(); + // Create a temp_ctx only for create_expr_tree. + VExprContextSPtr temp_ctx; + RETURN_IF_ERROR(VExpr::create_expr_tree(expr, temp_ctx)); + _virtual_column_expr = temp_ctx->root(); + // Virtual column expr should do prepare with original context. + RETURN_IF_ERROR(_virtual_column_expr->prepare(state, desc, context)); + _prepare_finished = true; + return Status::OK(); +} + +Status VirtualSlotRef::open(RuntimeState* state, VExprContext* context, + FunctionContext::FunctionStateScope scope) { + DCHECK(_prepare_finished); + RETURN_IF_ERROR(_virtual_column_expr->open(state, context, scope)); + RETURN_IF_ERROR(VExpr::open(state, context, scope)); + _open_finished = true; + return Status::OK(); +} + +Status VirtualSlotRef::execute(VExprContext* context, Block* block, int* result_column_id) { + if (_column_id >= 0 && _column_id >= block->columns()) { Review Comment: line 86 in prepare already check the _column_id < 0 return error. should here no need do _column_id >= 0 check ？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
