codeDing18 commented on code in PR #53376:
URL: https://github.com/apache/doris/pull/53376#discussion_r2224609626


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java:
##########
@@ -286,7 +288,14 @@ private void checkKeyColumnType(boolean isOlap) {
     public void validate(boolean isOlap, Set<String> keysSet, Set<String> 
clusterKeySet, boolean isEnableMergeOnWrite,
             KeysType keysType) {
         try {
-            FeNameFormat.checkColumnName(name);
+            // if enableFeatureOp is true, can add hidden column.
+            // So does not check if the column name starts with __DORIS_
+            if (enableFeatureOp) {
+                FeNameFormat.checkColumnNameExcludingHiddenColumn(name);

Review Comment:
   fixed



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java:
##########
@@ -574,6 +630,10 @@ public void 
addGeneratedColumnsThatReferToThis(List<String> list) {
         generatedColumnsThatReferToThis.addAll(list);
     }
 
+    public void setEnableFeatureOp(boolean enableFeatureOp) {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to