BiteTheDDDDt commented on code in PR #11985: URL: https://github.com/apache/doris/pull/11985#discussion_r954716012
########## be/src/olap/block_column_predicate.h: ########## @@ -57,6 +61,16 @@ class BlockColumnPredicate { virtual void evaluate_vec(vectorized::MutableColumns& block, uint16_t size, bool* flags) const {}; + + virtual bool evaluate_and(const std::pair<WrapperField*, WrapperField*>& statistic) const { + DCHECK(false) << "should not reach here"; Review Comment: Maybe we can just use `LOG(FATAL)` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org