luwei16 commented on code in PR #53408:
URL: https://github.com/apache/doris/pull/53408#discussion_r2217102516


##########
be/src/olap/olap_server.cpp:
##########
@@ -684,6 +684,22 @@ void StorageEngine::_compaction_tasks_producer_callback() {
                     last_base_score_update_time = cur_time;
                 }
             }
+            std::unique_ptr<ThreadPool>& thread_pool =
+                    (compaction_type == CompactionType::CUMULATIVE_COMPACTION)
+                            ? _cumu_compaction_thread_pool
+                            : _base_compaction_thread_pool;
+            if (config::compaction_num_per_round != 0) {
+                _compaction_num_per_round = config::compaction_num_per_round;
+            } else if (thread_pool->get_queue_size() == 0) {
+                // If all tasks in the thread pool queue are executed,
+                // double the number of tasks generated each time,
+                // with a maximum of 
config::max_automatic_compaction_num_per_round tasks per generation.

Review Comment:
   Need to consider the case where there are too many tasks in the queue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to