adonis0147 commented on code in PR #12039:
URL: https://github.com/apache/doris/pull/12039#discussion_r954443858
##########
tools/ssb-tools/bin/build-ssb-dbgen.sh:
##########
@@ -27,34 +27,34 @@ set -eo pipefail
ROOT=$(dirname "$0")
ROOT=$(
- cd "$ROOT"
+ cd "${ROOT}"
pwd
)
-CURDIR=${ROOT}
-SSB_DBGEN_DIR=$CURDIR/ssb-dbgen/
+CURDIR="${ROOT}"
+SSB_DBGEN_DIR="${CURDIR}/ssb-dbgen/"
# download ssb-dbgen first
-if [[ -d $SSB_DBGEN_DIR ]]; then
- echo "Dir $CURDIR/ssb-dbgen/ already exists. No need to download."
+if [[ -d ${SSB_DBGEN_DIR} ]]; then
+ echo "Dir ${CURDIR}/ssb-dbgen/ already exists. No need to download."
echo "If you want to download ssb-dbgen again, please delete this dir
first."
exit 1
else
- cd "$CURDIR"
- wget
https://palo-cloud-repo-bd.bd.bcebos.com/baidu-doris-release/ssb-dbgen-linux.tar.gz
&& tar -xzvf ssb-dbgen-linux.tar.gz -C $CURDIR/
+ cd "${CURDIR}"
+ wget
https://palo-cloud-repo-bd.bd.bcebos.com/baidu-doris-release/ssb-dbgen-linux.tar.gz
&& tar -xzvf ssb-dbgen-linux.tar.gz -C "${CURDIR}"/
fi
# compile ssb-dbgen
-cd "$SSB_DBGEN_DIR/" && make
+cd "${SSB_DBGEN_DIR}/" && make
Review Comment:
The same as the above.
##########
tools/ssb-tools/bin/build-ssb-dbgen.sh:
##########
@@ -27,34 +27,34 @@ set -eo pipefail
ROOT=$(dirname "$0")
ROOT=$(
- cd "$ROOT"
+ cd "${ROOT}"
pwd
)
-CURDIR=${ROOT}
-SSB_DBGEN_DIR=$CURDIR/ssb-dbgen/
+CURDIR="${ROOT}"
+SSB_DBGEN_DIR="${CURDIR}/ssb-dbgen/"
# download ssb-dbgen first
-if [[ -d $SSB_DBGEN_DIR ]]; then
- echo "Dir $CURDIR/ssb-dbgen/ already exists. No need to download."
+if [[ -d ${SSB_DBGEN_DIR} ]]; then
+ echo "Dir ${CURDIR}/ssb-dbgen/ already exists. No need to download."
echo "If you want to download ssb-dbgen again, please delete this dir
first."
exit 1
else
- cd "$CURDIR"
- wget
https://palo-cloud-repo-bd.bd.bcebos.com/baidu-doris-release/ssb-dbgen-linux.tar.gz
&& tar -xzvf ssb-dbgen-linux.tar.gz -C $CURDIR/
+ cd "${CURDIR}"
+ wget
https://palo-cloud-repo-bd.bd.bcebos.com/baidu-doris-release/ssb-dbgen-linux.tar.gz
&& tar -xzvf ssb-dbgen-linux.tar.gz -C "${CURDIR}"/
Review Comment:
Using `&&` may eat the errors. See #11357 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
